Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract-text-plugin isn't compatible with webpack 2 anymore #401

Closed
jantimon opened this issue Aug 12, 2016 · 14 comments
Closed

extract-text-plugin isn't compatible with webpack 2 anymore #401

jantimon opened this issue Aug 12, 2016 · 14 comments

Comments

@jantimon
Copy link
Owner

extract-text-plugin isn't compatible with webpack 2 anymore and therefore all examples are broken for webpack 2.

unfortunately the integration tests use those examples to verify that the webpack-html-plugin is compatible with webpack 2.

@robwise
Copy link

robwise commented Aug 18, 2016

what about using extract-text-plugin 2.0.0-beta.3 since it's webpack-2 compatible?

@jantimon
Copy link
Owner Author

Then we would have to drop all webpack 1 integration tests as extract-text-plugin 2 is not compatible with webpack 1

@numical
Copy link
Contributor

numical commented Sep 28, 2016

Hi Jan,
FYI.
I dealt with this issue for style-ext-html-webpack-plugin using a quick monkey-patch of Module._load - see the test code.
I have hived off the monkey-patch into its own module.
Once this module is out of alpha (i.e. I have written some tests for it) would you be interested in a PR for html-webpack-plugin on these lines)?

@jantimon
Copy link
Owner Author

Well we would also have to change all tests.. so installing is not a problem

@LoicMahieu
Copy link

@jantimon
Copy link
Owner Author

@LoicMahieu but not webpack1

@bebraw
Copy link

bebraw commented Dec 26, 2016

There's a problem that's specific to running HMR in multiStep mode as discussed webpack/webpack#2985 .

To quote Tobias:

the hot update chunks are also "chunk assets" and it looks like that the html-plugin generates a script tag for them.
html-plugin should use the new stats.entrypoints data to generate the script tags. This contains all needed files for an entrypoint in correct order.

If you want, I can open a separate issue to track this.

@jantimon
Copy link
Owner Author

jantimon commented Dec 28, 2016

Sure please - is there any developer documentation on stats.entrypoints?
Is there any way to get this backwards compatible - like backporting stats.entrypoints to webpack 1?

@bebraw
Copy link

bebraw commented Dec 28, 2016

Sure please - is there any developer documentation on stats.entrypoints?

Not that I know of.

Is there any way to get this backwards compatible - like backporting stats.entrypoints to webpack 1?

I expect some ugly check like require('webpack/package.json').version might be needed unless the plugin instance passes a version field.

I'll open a separate issue and get Tobias in the loop.

@luishdz1010
Copy link

Is there a known workaround to make html-webpack-plugin work with webpack 2?

@brandonb927
Copy link

@luishdz1010 I am running webpack 2.2, am fairly new to webpack itself as well, and have html-webpack-plugin running fine

@bebraw
Copy link

bebraw commented Jan 19, 2017

To my understanding only HMR multiStep option is broken with webpack 2 as discussed at #533.

@bebraw
Copy link

bebraw commented Jan 22, 2017

@luishdz1010 Are you having any particular issues with it?

@lock
Copy link

lock bot commented May 31, 2018

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants