Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some icons are not generated, why? #352

Open
Kcko opened this issue Jul 11, 2023 · 2 comments
Open

Some icons are not generated, why? #352

Kcko opened this issue Jul 11, 2023 · 2 comments
Labels

Comments

@Kcko
Copy link

Kcko commented Jul 11, 2023

Hi, in my build (generated via Vue + Webpack) im missing to many icons

eg:

  • /assets/apple-touch-startup-image-320x460.png
  • /assets/apple-touch-startup-image-640x920.png

My list has many different sizes

My logo has about 2000px (PNG)

HTML injection list of generated links with icons from doc https://github.com/jantimon/favicons-webpack-plugin#html-injection looks different from https://github.com/itgalaxy/favicons#usage

Webpack config (standard configuration)
new FaviconsWebpackPlugin({
        // Your source logo (required)
        logo: './logo.png',
        // Enable caching and optionally specify the path to store cached data
        // Note: disabling caching may increase build times considerably
        cache: true,
        // Override the publicPath option usually read from webpack configuration
        // publicPath: '/static',
        // The directory to output the assets relative to the webpack output dir.
        // Relative string paths are allowed here ie '../public/static'. If this
        // option is not set, `prefix` is used.
        // outputPath: '/public/static',
        // Prefix path for generated assets
        prefix: 'assets/',
        // Inject html links/metadata (requires html-webpack-plugin).
        // This option accepts arguments of different types:
        //  * boolean
        //    `false`: disables injection
        //    `true`: enables injection if that is not disabled in html-webpack-plugin
        //  * function
        //    any predicate that takes an instance of html-webpack-plugin and returns either
        //    `true` or `false` to control the injection of html metadata for the html files
        //    generated by this instance.
        inject: false,
        devMode: 'light',

        // Favicons configuration options (see below)
        favicons: {
          appName: '***',
          appDescription: '***',
          developerName: '***.',
          developerURL: 'http:https://andweb.cz', // prevent retrieving from the nearest package.json
          background: '#fff',
          theme_color: '#ffffff'
        }
      })

Where do I get the sizes that are listed or how do I configure it? Where is the betrayal? Or how i get fresh HTML injection list which will be correct?

Many thx.

@andy128k
Copy link
Collaborator

No worries. Readme-files are not always up to date. Some of those resolutions are related to not supported devices.
E.g. 320x480 is a resolution of iPhone 1st gen and 640x960 is a resolution of iPhone 4. Both are effectively dead.

@anvme
Copy link

anvme commented Aug 30, 2023

hey! My iPhone 4 works. It's not dead =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants