-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate with Rails rescue_from
to support custom 5xx error pages
#15
Comments
Yes, I agree it would make sense for rodauth-rails to call |
Excellent! Thank you! |
We'll need the |
Alright, I'll revise my PR for Rodauth as per Jeremy's feedback in the next day or so. |
@bjeanes I've just pushed changes to the |
I'll give it a go soon! 🙏 |
Hey Janko, I gave it a little spin this afternoon. Great work as always!
I don't use |
Thank you very much for testing 👍 Ok, I checked the Regarding |
Ack. I thought that might be the case for CSRF but wasn't sure. Glad to see you've already thought of it :D. One thing I thought of last night: it may be worth seeing if you can force |
I pushed new changes to Regarding allowing the controller to modify the response, I've allowed modifying the response headers at any point of the callback chain. This change also adds Action Dispatch default headers to Rodauth responses, which may be convenient as many of them are security-related. At this moment changing response body or status isn't possible in callbacks, unless you want to take over from the controller and render your own response. I felt like that would be a too big change around how is in charge, I don't know if that would have other unintended consequences. Could you give the branch another go? |
👍
TBH, I'm not even sure if/how Rails handles that. But I thing it really is such a niche use-case that I fully support not inheriting a lot of complexity here, at least until somebody actually communicates a desperate need for it!
You bet -- I'll give it a spin on Monday! |
Works a charm. I am going to push up this and make sure all the tests still run and then maybe we can see if Jeremy is ready to cut a new version which includes |
Everything is green on my end. How do you want to approach a release, given it depends on unreleased work in Rodauth? @jeremyevans do you have a timeline or milestone in mind for cutting a new Rodauth release? |
rescue_from
to support custom 5xx error pages
Next Rodauth release will probably be on the 20th (5 days) or 23th (8 days). Happy to do the former if that is preferred. |
I am in no urgent rush, so either suits me. I'm not presently seeing any 5xx errors in production on these pages anyway :) Thanks for the update! |
I've just released rodauth-rails 0.6.0 with these changes 🚀 The release also includes a new |
Hah is this in response to my Reddit comment? Looks great! I will be afk for a week and then spotty for a few more weeks, but I will try to integrate with app ASAP :D |
Hey Janko,
Do you have any advice on how to re-use the existing styled 5xx pages on the Rails' side for exceptions which happen in Rodauth land? Is this something rodauth-rails could/should cover in its integration?
I wonder if the
around_rodauth
we discussed in #2 (comment) might be necessary or even if that would simply work ifprocess_actions
is also responsible for Rails'rescue_from
behaviour (I haven't checked).The text was updated successfully, but these errors were encountered: