Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghprb Github Pull Request Merger should update state before merge attempted #477

Open
generatz opened this issue Dec 21, 2017 · 0 comments

Comments

@generatz
Copy link

Currently, if a build is successful, an appropriately configured Github Pull Request Merger attempts the merge. But if the target branch is protected with status checks and some other required status is a failure, the merge fails and ghprb posts a 'failure' status for the build.

This is misleading and logically incorrect, since the build did succeed. I would suggest that ghprb post a build 'success' status BEFORE the merge is attempted. If the merge fails, then the ghprb status could be overwritten with a different description, or a 'failure' status could be posted with a different context that is intended only to reflect the outcome of the attempted merge - not the build.

See also https://stackoverflow.com/questions/47891784/jenkins-github-pull-request-merger-does-not-respect-statuses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant