Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: also show undownloaded models in Model Tab > Model Selector Dropdown #3043

Closed
1 task done
imtuyethan opened this issue Jun 14, 2024 · 4 comments
Closed
1 task done
Assignees
Labels
Milestone

Comments

@imtuyethan
Copy link
Contributor

imtuyethan commented Jun 14, 2024

  • I have searched the existing issues

Is your feature request related to a problem? Please describe it

Right now search result only shows what model i have downloaded

Describe the solution

I should be able to search by configured model
Ex:

  • I search "Llama"
  • Show all related models: model i downloaded first -> model i havent downloaded

Teachability, documentation, adoption, migration strategy

No response

What is the motivation / use case for changing the behavior?

Original design was i dont need to go to Hub
Hub is for when i want to read model info more in details
if i already knew what model i want -> search -> download

Uploading image.png…

@Van-QA
Copy link
Contributor

Van-QA commented Jul 1, 2024

@urmauur, current UI is: n‌ot‌ downloaded modeld > downloa‌‌‌ded models, can you double che‌ck? I think @imtuyethan w‌ant the downloaded models on top

Image

@Van-QA
Copy link
Contributor

Van-QA commented Aug 23, 2024

Af‌ter the rollback of Jan x Cortex, only whe‌‌n users is not ‌having any m‌odel‌, th‌e‌y can search via the dropdown. But w‌hen there are models a‌‌vailable, then the re‌com‌‌mendation for download is n‌o longer visible ❌ @urmauur
image

@0xSage 0xSage changed the title feat: User should be able to search by configured model in model dropdown menu feat: also show undownloaded models in Model Tab > Model Selector Dropdown Sep 5, 2024
@0xSage
Copy link
Contributor

0xSage commented Sep 5, 2024

@imtuyethan I think this issue needs a bit more planning and is currently not well thought out.

It sounds like you want to:

Goal: improve discoverability from the Model Selector Dropdown , without users having to navigate to Hub.

Questions:

  1. Then shouldn't we also allow users to set up remote model API keys in the dropdown?
  2. When users click download from within dropdown, what does UI look like?
  3. Do we show all quantizations? It will be a long list...
  4. What if users want to see more information? How will they get to hub from model selector

@imtuyethan
Copy link
Contributor Author

@imtuyethan I think this issue needs a bit more planning and is currently not well thought out.

It sounds like you want to:

Goal: improve discoverability from the Model Selector Dropdown , without users having to navigate to Hub.

Questions:

  1. Then shouldn't we also allow users to set up remote model API keys in the dropdown?
  2. When users click download from within dropdown, what does UI look like?
  3. Do we show all quantizations? It will be a long list...
  4. What if users want to see more information? How will they get to hub from model selector

Ah this one is done on v0.5.3-628.

I think this one is a killing feature because of how convenient it is:

Scenario 1:

  • I have a list of available model
  • I have a specific model in mind that i don't have yet
  • I search for it -> download it directly without having to go to Hub
    Hub is for model discovery, not for when i already have a specific model in mind.

Scenario 2:

  • I want to use Mistral Instruct because i though i had it
  • I search for it then realize I haven't downloaded it yet -> Download it directly
    Normally when i search for it and don't see it, i have to go to Hub & search & download & then come back to threads, so many steps...
Screen.Recording.2024-09-11.at.8.20.21.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

4 participants