Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: v0.4.12 Every new thread created is reset to 2048 token context length #2821

Open
Propheticus opened this issue Apr 25, 2024 · 4 comments
Assignees
Labels
P1: important Important feature / fix type: bug Something isn't working
Milestone

Comments

@Propheticus
Copy link

Like the title says the default value is set for every new thread. After picking a model where the model.json defines a ctx_len of e.g. 20000, the context is still set to 2048. After you manually adjust this and load the model, when you open a new thread the default is still reset to 2048. Dragging the slider in the new thread kills nitro and unloads the model.
image

Related? : https://github.com/janhq/jan/blob/dev/extensions/inference-nitro-extension/resources/default_settings.json

@Propheticus Propheticus added the type: bug Something isn't working label Apr 25, 2024
@louis-jan
Copy link
Contributor

louis-jan commented Apr 25, 2024

Hi @Propheticus, this is a minor update to ensure that new models with large context lengths (>8k) do not crash low-spec devices.

We will add a global setting to the extension or check device specs using heuristics to determine the proper settings.

@louis-jan louis-jan self-assigned this Apr 25, 2024
@Propheticus
Copy link
Author

I can understand that reason. The main issue I had is that it's done silently for new threads, even after overriding it manually when loading the model. Without checking the model's engine parameters you wouldn't know your setting was undone.

@louis-jan
Copy link
Contributor

I can understand that reason. The main issue I had is that it's done silently for new threads, even after overriding it manually when loading the model. Without checking the model's engine parameters you wouldn't know your setting was undone.

Yeah, that sucks. We'll address this in the next release.

@louis-jan louis-jan added this to the v0.4.13 milestone Apr 25, 2024
@louis-jan louis-jan modified the milestones: v0.5.0 Broken Rice, v0.5.1 May 3, 2024
@Van-QA
Copy link
Contributor

Van-QA commented May 29, 2024

should be resolved via janhq/cortex#617

@imtuyethan imtuyethan assigned namchuai and unassigned louis-jan Jul 2, 2024
@imtuyethan imtuyethan added the P1: important Important feature / fix label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1: important Important feature / fix type: bug Something isn't working
Projects
Status: Planned
Development

No branches or pull requests

5 participants