Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: error when model is too big for user's device RAM #1627

Closed
Tracked by #1430
imtuyethan opened this issue Jan 16, 2024 · 7 comments
Closed
Tracked by #1430

feat: error when model is too big for user's device RAM #1627

imtuyethan opened this issue Jan 16, 2024 · 7 comments
Assignees
Labels
P1: important Important feature / fix type: enhancement New feature or request type: feature request A new feature
Milestone

Comments

@imtuyethan
Copy link
Contributor

Problem

Though we do not know all the reasons of somethin's amiss, but we do know that if users use not enough RAM model it will show the same error, let's separate this case & write a different error message for it.
Context:
Screenshot_2024-01-15_at_6 23 40_PM

New copies

Figma link
Oops! Model size exceeds available RAM. Consider selecting a smaller model or upgrading your RAM for smoother performance.

Screenshot 2024-01-16 at 5 33 11 PM
@Van-QA
Copy link
Contributor

Van-QA commented Jan 24, 2024

Tested and looking good on Jan v0.4.4-169 ✅

image

@Van-QA Van-QA closed this as completed Jan 24, 2024
@imtuyethan imtuyethan reopened this Feb 2, 2024
@imtuyethan
Copy link
Contributor Author

Reopen as this issue is not solved cc @Van-QA @louis-jan @urmauur

My app log:
app.log

Screen.Recording.2024-02-02.at.3.51.30.PM.mov

@urmauur
Copy link
Contributor

urmauur commented Feb 6, 2024

@imtuyethan i think it's model failed load in your video mean while the ticket when model is too big for user's device RAM

for test this ticket you need successfully load and model with label not enough RAM cc @Van-QA @louis-jan

@louis-jan
Copy link
Contributor

Thank you for the first check @urmauur. Now is my turn for the nitro crash & error handling.

@louis-jan
Copy link
Contributor

louis-jan commented Mar 7, 2024

Failed QA during 0.4.8, will move to 0.4.9 0.4.10 🙏

@Van-QA Van-QA modified the milestones: v0.4.9, v0.4.10 Mar 11, 2024
@Van-QA Van-QA mentioned this issue Mar 27, 2024
6 tasks
@Van-QA Van-QA modified the milestones: v0.4.10, v0.4.11 Mar 28, 2024
@louis-jan
Copy link
Contributor

The previous fix is no longer relevant. A fix from llama.cpp (inference engine) has addressed the issue. For now, there is no way to distinguish. I will investigate further.

@Van-QA Van-QA modified the milestones: v0.4.11, v0.4.12 Apr 4, 2024
@Van-QA Van-QA modified the milestones: v0.4.12, v0.4.13 Apr 17, 2024
@louis-jan louis-jan added P1: important Important feature / fix and removed P0: critical Mission critical labels Apr 25, 2024
@Van-QA Van-QA modified the milestones: v0.5.0 Broken Rice, v0.5.1 May 2, 2024
@imtuyethan
Copy link
Contributor Author

deprecated as after Hub revamp, we will no longer allow user to download model that is too big for their RAM

@imtuyethan imtuyethan closed this as not planned Won't fix, can't repro, duplicate, stale Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1: important Important feature / fix type: enhancement New feature or request type: feature request A new feature
Projects
Archived in project
Development

No branches or pull requests

4 participants