Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Profile tab sometimes disappears #3114

Closed
ann0see opened this issue Jul 26, 2023 · 8 comments · Fixed by #3110
Closed

My Profile tab sometimes disappears #3114

ann0see opened this issue Jul 26, 2023 · 8 comments · Fixed by #3110
Assignees
Labels
bug Something isn't working

Comments

@ann0see
Copy link
Member

ann0see commented Jul 26, 2023

Describe the bug

Sometimes with at Qt 6.5.1 based builds, the My Profile tab disappears. See #3099 (comment)

To Reproduce
We don't know.

  • Freshly install Jamulus
  • Open Settings
  • Sometimes observe that My Profile doesn't show up

Expected behavior

My Profile always shows up

Screenshots

Not reproducible

Operating system

Happens on Windows and Linux, Probably macOS too.

Version of Jamulus
Unsure, but not yet released version from main.

Additional context

Probably a Qt 6.5 bug. @pljones initially experienced it.

@ann0see ann0see added the bug Something isn't working label Jul 26, 2023
@ann0see
Copy link
Member Author

ann0see commented Jul 26, 2023

I'd downgrade Qt 6 for the release if we can't fix this.

@ann0see ann0see added this to the Release 3.10.0 milestone Jul 26, 2023
@ann0see ann0see changed the title My Profile sometimes disappears My Profile tab sometimes disappears Jul 26, 2023
@pljones
Copy link
Collaborator

pljones commented Jul 26, 2023

I was wondering (and haven't had a chance to investigate) whether this is a change between a client running Qt5 and then being upgraded with the same profile to Qt6. When did, for example, the country codes in the profile change? Or the flags?

@pljones
Copy link
Collaborator

pljones commented Jul 26, 2023

OK... Some initial investigations.

Pulled from jamulussoftware/jamulus main to my main.

1736d2ad 2023-07-24 (HEAD -> main, upstream/main, origin/main) Merge pull request #3077 from ann0see/licensing/addGPLHeader [Peter L Jones]

Run Jamulus, click the "Settings" checkbox.

Clean profile, Qt5.12.2 run from QtCreator:
image

Clean profile, Qt6.5.1 run from QtCreator:
image

Clean profile, Qt6.5.1 from Github build
image
(Hm, the Windows build from #3099 jamulus_3.9.1dev-9638ef2_win.exe still has 6.5.1 - I was expecting 6.5.2?)


Once the incredibly slow Qt server lets me have Qt6.5.2, I'll get on and try that.

@pljones
Copy link
Collaborator

pljones commented Jul 26, 2023

OK, Qt6.5.2 with the same build, clean profile:
image

So, maybe it's sorted in Qt6.5.2...

@pljones
Copy link
Collaborator

pljones commented Jul 29, 2023

#3110 may fix this, then?

Are we using Qt6 < 6.5.2 for any build?

@ann0see
Copy link
Member Author

ann0see commented Jul 29, 2023

Are we using Qt6 < 6.5.2 for any build?

No. I don't think so

@pljones
Copy link
Collaborator

pljones commented Jul 29, 2023

Also checked and replicated the behaviour on Linux Qt6.5.1 vs Qt6.5.2 - looks like they've fixed it.

@pljones pljones linked a pull request Jul 29, 2023 that will close this issue
@pljones
Copy link
Collaborator

pljones commented Jul 29, 2023

Linked to #3110, which appears to be the fix.

@pljones pljones closed this as completed Jul 29, 2023
@pljones pljones self-assigned this Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants