Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

randomkey method is not implemented, but is not in the list of unimplemented commands #106

Closed
Jwpe opened this issue Feb 11, 2016 · 3 comments

Comments

@Jwpe
Copy link

Jwpe commented Feb 11, 2016

Relevant code:

https://github.com/jamesls/fakeredis/blob/master/fakeredis.py#L356

Relevant documentation:

https://github.com/jamesls/fakeredis#unimplemented-commands

There's a discrepancy here. Would it be better to implement the randomkey method, or just add it to the list of unimplemented commands?

@thedrow
Copy link
Contributor

thedrow commented Apr 11, 2016

Why not implement it?

@jamesls
Copy link
Owner

jamesls commented Aug 16, 2016

Sorry for the delay. I'd prefer to implement. Might be difficult to write a reliable unit test for this, but it would be great to have this implemented.

@bmerry
Copy link
Collaborator

bmerry commented Mar 23, 2018

Fixed by removing the stub implementations and adding to the list of unimplemented commands. An implementation would still be welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants