Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

websocket.userData not working anymore [FOUND A FIX] #728

Open
kasugasorata98 opened this issue Sep 9, 2021 · 4 comments · May be fixed by #732
Open

websocket.userData not working anymore [FOUND A FIX] #728

kasugasorata98 opened this issue Sep 9, 2021 · 4 comments · May be fixed by #732

Comments

@kasugasorata98
Copy link

kasugasorata98 commented Sep 9, 2021 •
edited
Loading

The latest version of 0.13.0
Wrong terniary operator:
Binance.options.execution_callback = execution_callback ? callback : execution_callback;
Correction:
Binance.options.execution_callback = execution_callback ? execution_callback : callback;
@kasugasorata98 kasugasorata98 changed the title websocket.userData [ 'Parse error: data.B is not iterable' ] websocket.userData not working anymore [FOUND A FIX] Sep 9, 2021
gunar added a commit to gunar/node-binance-api that referenced this issue Sep 22, 2021
@gunar
Revert "This change is required to listen for Orders"
799711c 
Fixes jaggedsoft#728
See also jaggedsoft#695

This reverts commit 9af22e7.
@gunar gunar linked a pull request Sep 22, 2021 that will close this issue
Open
@gunar
Copy link
Contributor

gunar commented Sep 22, 2021

@kasugasorata98 thanks! this was very useful for me to open #732

@BaptisteGarcin BaptisteGarcin mentioned this issue Sep 24, 2021
Open
@mr-smit
Copy link

mr-smit commented Nov 6, 2021 •
edited
Loading

you just use it wrong, its working in 0.13.0


	function order_update(data) {
		console.log(data)
	}
	binance.websockets.userData(order_update, true);

@luiztools
Copy link

No, it isn't @mr-smit. In 0.12.5 you could pass different callbacks for different updates from the stream and in 0.13.0 you can't anymore because of this wrong logic.

Any news @gunar ?

@gunar
Copy link
Contributor

gunar commented Nov 7, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix execution updates stream gunar/node-binance-api
5 participants
@luiztools @gunar @mr-smit @kasugasorata98 and others