Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove yarn resolution for @types/react #1968

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Remove yarn resolution for @types/react #1968

merged 2 commits into from
Nov 10, 2023

Conversation

anshgoyalevil
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • This PR removes resolution for types/react.
  • Since the error described in [Bug]: dependabot updates are broken #1964 indicates that depandabot tried to upgrade @types/react from 18.2.33 to 18.2.37 but because of no yarn.lock change, it failed.
  • Yarn.lock wasn't changed in case of depandabot because of resolution.

How was this change tested?

  • CI

Checklist

@anshgoyalevil anshgoyalevil requested a review from a team as a code owner November 10, 2023 19:32
@anshgoyalevil anshgoyalevil requested review from joe-elliott and removed request for a team November 10, 2023 19:32
@codecov Codecov
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

yurishkuro
yurishkuro reviewed Nov 10, 2023
View reviewed changes
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this PR, but I noticed that you're bumping the lib manually. The latest dependabot PR did bump the lock file for it, but not the explicitly declared version. That was a strange behavior imo, usually it does both, so I am wondering if the resolution is what prevented it from bumping explicit deps. What if we try this PR with removing resolution but without bumping explicit deps?

@yurishkuro yurishkuro added the changelog:dependencies Update to dependencies label Nov 10, 2023
anshgoyalevil
anshgoyalevil commented Nov 10, 2023
View reviewed changes
packages/jaeger-ui/package.json Outdated
@@ -17,7 +17,7 @@
"@babel/preset-typescript": "^7.21.0",
"@testing-library/jest-dom": "^6.0.0",
"@testing-library/react": "^14.0.0",
"@types/react": "^18.2.33",
"@types/react": "^18.2.37",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part gets modified too when depandabot tries to upgrade deps even with resolution. Strange why this didn't happen with PR #1967

@anshgoyalevil
revert upgrade
8335292 
Signed-off-by: Ansh Goyal <[email protected]>
@yurishkuro yurishkuro enabled auto-merge (squash) November 10, 2023 19:56
@anshgoyalevil
Copy link
Member Author

I am fine with this PR, but I noticed that you're bumping the lib manually. The latest dependabot PR did bump the lock file for it, but not the explicitly declared version. That was a strange behavior imo, usually it does both, so I am wondering if the resolution is what prevented it from bumping explicit deps. What if we try this PR with removing resolution but without bumping explicit deps?

Hmm. I agree with this. We should leave the upgrade on depandabot to see its behavior now

@yurishkuro yurishkuro merged commit dcd26de into jaegertracing:main Nov 10, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@joe-elliott joe-elliott Awaiting requested review from joe-elliott joe-elliott is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:dependencies Update to dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: dependabot updates are broken
2 participants
@anshgoyalevil @yurishkuro