Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump react-json-view-lite library to v1.0.0 and resolve all breaking changes #1808

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Bump react-json-view-lite library to v1.0.0 and resolve all breaking changes #1808

merged 1 commit into from
Sep 19, 2023

Conversation

priyanshu-kun
Copy link
Contributor

@priyanshu-kun priyanshu-kun commented Sep 19, 2023 •
edited
Loading

Which problem is this PR solving?

Description of the changes

  • This pull request upgrades the React-Json-View-Lite library to version 1.0.0 and fix important breaking changes.

Checklist

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
.../TraceTimelineViewer/SpanDetail/KeyValuesTable.tsx 100.00%

📢 Thoughts on this report? Let us know!.

@priyanshu-kun priyanshu-kun changed the title Bump react-json-view-lite library and resolve all major changes Bump react-json-view-lite library to v1.0.0 and resolve all major changes Sep 19, 2023
@priyanshu-kun priyanshu-kun changed the title Bump react-json-view-lite library to v1.0.0 and resolve all major changes Bump react-json-view-lite library to v1.0.0 and resolve all breaking changes Sep 19, 2023
@yurishkuro
Copy link
Member

Please include screenshot of expanders

@priyanshu-kun
Copy link
Contributor Author

Please include screenshot of expanders

Before making change in jaeger for this PR, I was tested react-json-view-litev1.0.0 by making a dummy react app because I don't know how do I tested it in jaeger itself. Thus, I create that dummy app and in that app the expanders, collapsers and collapseContent icons looks on point, I'm attaching a screen cast of the dummy app. Moreover, I will test this in jaeger tomorrow, first of all, I have to figure out jaeger working by building a simple microservice app.
Screencast from 19-09-23 11:58:36 PM IST.webm

@yurishkuro
Copy link
Member

thanks, the s/s looks fine.

You do not need to "build an app" to test, Jaeger comes with HotROD that can generate interesting traces.

@yurishkuro yurishkuro merged commit c788ce6 into jaegertracing:main Sep 19, 2023
9 checks passed
@yurishkuro yurishkuro mentioned this pull request Sep 19, 2023
Closed
@priyanshu-kun priyanshu-kun deleted the priyanshu-kun/#1797 branch September 19, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[deps] Upgrade react-json-view-lite
2 participants
@priyanshu-kun @yurishkuro