Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padding isn't removed from input when instance is destroyed #1697

Closed
john-ackerman opened this issue Jul 11, 2024 · 2 comments
Closed

Padding isn't removed from input when instance is destroyed #1697

john-ackerman opened this issue Jul 11, 2024 · 2 comments

Comments

@john-ackerman
Copy link

Plugin version

v23.1.1

Steps to reproduce

  1. Apply intl-tel-input to an input element with separateDialCode set to true
  2. Destroy the intl-tel-input instance that was created

Expected behaviour

The padding that is added to prevent text from overlapping with the dial code should be removed when intl-tel-input is destroyed

Actual behaviour

The padding remains and must be manually removed

Initialisation options

separateDialCode

From what I can tell this isn't an issue when separateDialCode is set to false, because that doesn't add a style tag to the element.

@jackocnr
Copy link
Owner

Good catch, thanks. I'm afraid I don't have time to implement this myself right now, but I would be open to a pull request.

@jackocnr
Copy link
Owner

Fixed in v23.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants