Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent 4:3 ratio flag images #1668

Open
jackocnr opened this issue Jun 22, 2024 · 0 comments
Open

Consistent 4:3 ratio flag images #1668

jackocnr opened this issue Jun 22, 2024 · 0 comments

Comments

@jackocnr
Copy link
Owner

jackocnr commented Jun 22, 2024

Currently, some flags are 15px tall e.g. Vatican City, and some are only 8px tall e.g. Qatar. And while most flags are 20px wide e.g. United Kingdom, some are only 13px wide e.g. Nepal. So if we select those 4 countries as our onlyCountries option, we end up with a situation like this:

current

Whereas if we switch to a different flag library, which uses consistent 4:3 ratio (as suggested by @bronisMateusz), we end up with this instead:

new

Which, while not being technically accurate in terms of respecting countries' flag shapes, provides a much more consistent UI experience.

This change will require updating/replacing the existing image build system, which will become much simpler!

I don't have time to implement this myself right now, but would welcome a pull request.

Ideally, the flag sprite will be output in AVIF format, though that shouldn't be a blocker to getting this out, as it can easily be added as a subsequent build step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant