-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default global icon for invalid dial code #1646
Comments
If you can find the minimal set of code that reproduces the problem and put that in a CodePen, then I'd be happy to take a look. Here is an example pen with the plugin up and running - feel free to fork this if it helps. |
It seems to work fine here: https://codepen.io/jackocnr/pen/NWVgMRp?editors=1010 So I'm not sure what the problem is. Can you reproduce it in a codepen? |
The problem occurs when I use https://ipinfo.io/json
|
Yes well it doesn't make sense to initialise the plugin with a phone number in the input, and then to set initialCountry=auto. If you already have a number, then you must already know the country, so either you (A) include the international dial code in the initial input value, which will automatically update the selected country (recommended), or (B) use initialCountry to set the correct country for the given number. |
Initialize the plugin with a phone number in the input field in cases where we have a list of registered users with phone numbers but without country dial codes. Users will need to manually update the dial code after we integrate this plugin. Therefore, only the arrow showing may result in poor user experience. |
Ok I'll take a look when I have a moment, and try to get it so it always shows either a flag or the globe icon no matter what initialisation options are used. |
Fix released in v23.0.11 - give it a try and let me know if it works for you! |
Confirmed, it works. Thank you. |
Plugin version
e.g. v23.0.10 (please try latest version)
Steps to reproduce
Expected behaviour
Display a global icon if there is a default phone number already set with an invalid dial code.
Actual behaviour
Only arrow dropdown showing
The text was updated successfully, but these errors were encountered: