Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawing the wheel always with full brightness #9

Closed
Ape opened this issue Oct 8, 2017 · 4 comments
Closed

Drawing the wheel always with full brightness #9

Ape opened this issue Oct 8, 2017 · 4 comments
Assignees

Comments

@Ape
Copy link

Ape commented Oct 8, 2017

I'd like to have an option for always drawing the wheel with full brightness (V channel = 100%) regardless of the slider value.

@jaames jaames self-assigned this Oct 13, 2017
@jaames
Copy link
Owner

jaames commented Oct 13, 2017

Thank you for the suggestion!

So if I understand correctly, the idea is to optionally hide the value/brightness slider completely and just have the hue wheel? It seems reasonable, there's a couple of things I'd like to ask, though:

  • Any preference regarding the name of the "disable the brightness slider" option? I feel like setting valueSlider: false makes sense, but I'm open to suggestions.
  • How should the color picker behave when the color is set via JavaScript (e.g. colorPicker.color.hexString = "#000")? Should it force the color's V channel to be 100%?

Sorry for the slow response, by the way. :>

@Ape
Copy link
Author

Ape commented Oct 14, 2017

No, I don't want to hide the brightness slider. I still want to have it affect the actual output color value just as it does now.

The only think I want is to always render the wheel pretending the slider is at max brightness.

The behaviour and output values should remaing unchanged. This would change how the colors in the wheel are drawn.

@jaames
Copy link
Owner

jaames commented Oct 14, 2017

Ah I see, sorry for the confusion.

To be honest I'm hesitant to add this, I feel that this would be counter-intuitive for the user since the intention was for the middle of both control markers to be over the currently selected color at all times.

That said, if you wanted to, you could perhaps fork the library and change this line so that value = 100 permanently. Or if you're willing to wait, the new SVG-based UI being worked on in svg-ui branch will be much more flexible and will allow you to do what you want with just a line of CSS.

@jaames jaames closed this as completed Oct 15, 2017
@ringofhealth
Copy link

I think having the option to disable the brightness slider makes a lot of sense. What you proposed

valueSlider: false

as a part of the init setting makes a lot of sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants