Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Pass color param to callback function for the other events also #24

Closed
gadlol opened this issue Jan 26, 2018 · 1 comment
Closed
Assignees

Comments

@gadlol
Copy link

gadlol commented Jan 26, 2018

It would be nice to also pass color params to callback function for the events:

input:start and input:end

especially for input:end.

Right now we have to do:

demoColorPicker.on("input:end", function onInputEnd() {
  console.log(demoColorPicker.color.hexString);
});

It would be better to also do:

demoColorPicker.on("input:end", function onInputEnd(color) {
  console.log(color.hexString);
});
@gadlol gadlol changed the title Pass color param to callback function for other events also Pass color param to callback function for the other events also Jan 26, 2018
@gadlol gadlol changed the title Pass color param to callback function for the other events also Request: Pass color param to callback function for the other events also Jan 26, 2018
@jaames jaames self-assigned this Feb 4, 2018
@jaames
Copy link
Owner

jaames commented Mar 20, 2018

Sorry for such a slow response on this, I meant to get to it sooner. The color object should be available as a param for both the input:start and input:end events as of da84bd9 :)

@jaames jaames closed this as completed Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants