Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svg, display:block #23

Closed
gadlol opened this issue Jan 26, 2018 · 2 comments
Closed

Svg, display:block #23

gadlol opened this issue Jan 26, 2018 · 2 comments
Assignees

Comments

@gadlol
Copy link

gadlol commented Jan 26, 2018

In line 1380:

svgElement.call(this, this, parent, "svg", { width: width, height: height, style: "display:block" });

It would be better if that "display:block" was a param so we could add for example "display:inline-block".

@jaames
Copy link
Owner

jaames commented Jan 26, 2018

Thanks for the suggestion, I agree that it might be worthwhile to provide an option to change the SVG's display attribute. Will try adding it now :)

@jaames jaames self-assigned this Jan 26, 2018
@jaames
Copy link
Owner

jaames commented Jan 26, 2018

As of c080c12, iro.ColorPicker instances now have a display param that can be used to set the color picker's CSS display property. It will default to "block" to preserve past behaviour.

Docs have been updated to reflect this change: https://rakujira.jp/projects/iro/docs/guide.html#Color-Picker-Options

@jaames jaames closed this as completed Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants