New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: IE11 mouseup events #163

Closed

michaelfarrelly opened this issue Feb 17, 2021 · 1 comment

michaelfarrelly commented Feb 17, 2021

IE11 mouse up events are not removed fully, related to older issue #58:

https://github.com/jaames/iro.js/blob/master/src/ComponentWrapper.tsx#L95

Recommend change from MDN:
from: document.removeEventListener(event, this);
to: document.removeEventListener(event, this, { passive: false });

This matches the addEventListener options.

The text was updated successfully, but these errors were encountered:

jaames mentioned this issue

Add ability to pass index to setColors #162

Merged

Owner

jaames commented Feb 18, 2021

good catch! should be fixed in the next release (5.3.2)

jaames closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment