Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JOOX.$ should add an overload accepting a Path object #165

Closed
helpermethod opened this issue Jun 6, 2019 · 1 comment
Closed

JOOX.$ should add an overload accepting a Path object #165

helpermethod opened this issue Jun 6, 2019 · 1 comment
Labels
P: Medium R: Fixed T: Enhancement
Milestone
Version 2.0.0

Comments

@helpermethod
Copy link

Expected behavior and actual behavior:

Most modern Java APIs return objects of type Path or Stream<Path>. Having to convert every Path object to a File using path.toFile() seems tedious and unnecessary.

Because JOOX.$ already has quite a few overloads, another overload accepting a Path object wouldn't hurt.

Steps to reproduce the problem:

Joox.$(Path.of("/home/helpermethod")); // seems to work but selects the wrong overload

Versions:

  • jOOX: 1.6.0
  • Java: 8
@lukaseder lukaseder added this to the Version 1.7.0 milestone Jun 7, 2019
@lukaseder
Copy link
Member

Thank you very much for your suggestion. I agree this could be done

lukaseder added a commit that referenced this issue Mar 7, 2021
@lukaseder
[#165] JOOX.$ should add an overload accepting a Path object
e4d8627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P: Medium R: Fixed T: Enhancement
Projects
None yet
Milestone
Version 2.0.0
Development

No branches or pull requests
2 participants
@lukaseder @helpermethod