-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 2.0.0 - BREAKING CHANGES. Migration steps #350
Comments
UPDATE: We missed to mention about changes in the proxy support. Proxy is still available, albeit with a simple workaround echo service configured as CONFIG.PROXY_URL. See #354 (and we'll update example config soon) |
FYI, iframely with pm2 failed to start with node 12 at Debian 11. With node 14 it started without any problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Iframely is finally upgraded to the current node versions #344. Due to significant changes in the Node itself, there is sadly no backward compatibility.
The minimum version of the Node required for Iframely starting from version 2.0.0 is Node 12.
The good news is that we used this version in our cloud for a few months now, and it is proved stable.
Here's the migration checklist if you used Iframely with version less than 12:
import
statements.import
if you plug Iframely as the node module.config.local.js.EXAMPLE
Other significant change in 2.0.0 is the absence of
request
module, which was deprecated a while ago. We now rely on adobe/helix-fetch module, which we verified as being most production-ready among available alternatives. If you usedrequest
variable in your custom plugin methods, you'd need to test them with special attention.If you used Iframely with Node 12, it is likely that you have had HTTP/2 disabled due to #277. It is now resolved and HTTP/2 is enabled for all deployments. The system feature flag to turn it off is no longer available, but you can configure it as a proxy element.
UPDATE: Proxy is still available, albeit with a simple workaround echo service configured as
CONFIG.PROXY_URL
. See #354 (and we'll update example config soon)The text was updated successfully, but these errors were encountered: