Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default axis #36

Closed
sebastienwozny opened this issue Apr 26, 2019 · 1 comment
Closed

Default axis #36

sebastienwozny opened this issue Apr 26, 2019 · 1 comment

Comments

@sebastienwozny
Copy link

Hi @itmammoth and thanks for the gem!
Why have you specified the default axis "y" in your gem ?

It make more sens to me to keep the widget default parameter. (Made me crazy for twenty minutes before I understand)

rails_sortable/vendor/assets/javascripts/plugin.js

Line 6 in b4b273b

axis: 'y',

https://api.jqueryui.com/sortable/#option-axis

axis 
Type: String
Default: false

xoxo
@itmammoth
Copy link
Owner

Thanks @sebastienwozny
You have a point.
The default parameters should have been more respected.
I will make a change to it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@itmammoth @sebastienwozny