Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: naming consistency on OPC_GATEWAY_HOST and OPC_GATE_HOST #36

Open
jamesbraza opened this issue Jan 6, 2023 · 1 comment
Open
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jamesbraza
Copy link
Contributor

I am trying to get the OPC gateway service to work, and am observing a distinction between OPC_GATEWAY_HOST and OPC_GATE_HOST for the environment variable name:

  • OPC_GATE_HOST: seems to be correct, it's used in README and openopc2/config.py
  • When I install the service and run with debug, it prints OPC_GATEWAY_HOST
Open Opc Config:
OPC_HOST              : localhost
OPC_SERVER            : Matrikon.OPC.Simulation
OPC_CLIENT            : OpenOPC
OPC_GATEWAY_HOST      : 192.168.0.115
OPC_GATEWAY_PORT      : 7766

I would like to point out that the changing of names in the stdout is a potential source of confusion. Imo it's user-friendly to standardize the attribute names printed by the service with the environment variable names. Thank you for your consideration!

@renzop
Copy link
Collaborator

renzop commented Jan 6, 2023 via email

@eliabieri eliabieri added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants