-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iframe gets cropped instead of shrunk when page is below 1000px #1599
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When you shrink the browser window, my game gets cut off, rather than being resized. Under 1000px wide, the website limits the size of the content to 600px.
I have my games resolution set to 768x384 on itch, because I want it to be this big for normal desktop viewers, but it has the ability to render smaller. But instead of shrinking the iframe when the page is under 1000px, the webpage keeps it the same size, and just cuts it off (by putting
overflow:hidden
on#inner_column
.Not only does this make my game unplayable, you can't even click the fullscreen button any more, which would at least be a workaround, it too is cut off.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I would expect the game's iframe to be forced to be smaller to fit within the 600px window, or at least allowed to not be cut off. Cutting off a portion of the game screen would render nearly all games unplayable, whereas most games have the ability to render at difference resolutions, which is how the fullscreen button works.
Screenshots
![firefox_2024-05-29_22-25-39](https://private-user-images.githubusercontent.com/2721332/335019553-4b5439f7-8e2e-4a3b-aa1d-d674d9ab3d08.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE5Nzg1NTAsIm5iZiI6MTcyMTk3ODI1MCwicGF0aCI6Ii8yNzIxMzMyLzMzNTAxOTU1My00YjU0MzlmNy04ZTJlLTRhM2ItYWExZC1kNjc0ZDlhYjNkMDgucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcyNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MjZUMDcxNzMwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ODkzODg0OWMxYmU4YTg4MWUxMzRlMGQzNmE3OWNiNTBiYzFhZmM4MWUyZGI4YjJjMWQ4NjA4YWIyNzlmN2JjMSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.C6-XIBJtoNcc2VXJ_5bomchhufICVJLN7z-xFUqh7sk)
![firefox_2024-05-29_22-25-45](https://private-user-images.githubusercontent.com/2721332/335019557-3694e398-95a6-4882-b5a4-ffb77316e2c8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE5Nzg1NTAsIm5iZiI6MTcyMTk3ODI1MCwicGF0aCI6Ii8yNzIxMzMyLzMzNTAxOTU1Ny0zNjk0ZTM5OC05NWE2LTQ4ODItYjVhNC1mZmI3NzMxNmUyYzgucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcyNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MjZUMDcxNzMwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YzQ5YjQ0MDUwZWM4MWMwYTViMDkzNzhiZjY1NmU0ODdiMjJiNjM2YmY1M2E4NWFiNTM3ZWU0NTYzOTU5NjFmNSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.CO5RBJQWexA9zdwGCQ0bGg621XIndGMsVBXVqF3bn0A)
Here is a screenshot of above 1000px wide window, and below 1000px wide window
Desktop (please complete the following information):
Additional context
My game is not using an engine, just javascript, so maybe I'm doing something wrong, but I can't imagine im the first person to ever run into this issue. My game can render as small as 256x128, and while I could set the size on itch to be 512x256, i don't want it to have to render smaller for all desktop users just so a few people with smaller screens can play it.
Since the fullscreen button already changes the size of the iframe and expects your game to adapt accordingly, I don't think it's crazy to expect games to still work if you shrink the iframe to 600px. Perhaps there could be a setting on pages, but again i doubt any game is going to work with the right side of it cropped off.
Or at the very least, the game submission page should warn you to not to set the width higher than 600px.
The text was updated successfully, but these errors were encountered: