Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Istio Discovery’s helm chart is missing imagePullSecrets implementation #51653

Closed
2 tasks done
imtmcdonald opened this issue Jun 21, 2024 · 1 comment
Closed
2 tasks done
Labels
area/environments kind/need more info Need more info or followup from the issue reporter

Comments

@imtmcdonald
Copy link

imtmcdonald commented Jun 21, 2024

Is this the right place to submit this?

  • This is not a security vulnerability or a crashing bug
  • This is not a question about how to use Istio

Bug Description

I tried to deploy the istiod helm chart using a private registry and associated image pull secret.

Upon deployment, the pod failed with ErrImagePull. Describing the pod, it displayed an event complaining about unauthorized access to the private registry.

I checked the rendered helm chart for istiod and the image pull secret isn’t referenced anywhere in the chart. I also searched the charts for each various past versions and this looks to be an ongoing issue.

Please update istiod helm chart so it leverages imagepullsecrets.

Version

Kubectl version - 1.30
Helm chart version - latest
Chart - manifests/charts/istio-control/istio-discovery

Additional Information

There was a previous PR created to resolve this issue, but was closed with no comments.
Ref: #50139

@RicHincapie
Copy link

RicHincapie commented Jun 27, 2024

the imagePullSecret implementation for istiod is at its ServiceAcount level here.
From Kubernetes docs:

Now, when a new Pod is created in the current namespace and using the default ServiceAccount, the new Pod has its spec.imagePullSecrets field set automatically

You're probably hitting some other issue.

Pls let me know it this issue can be closed.

@howardjohn howardjohn added the kind/need more info Need more info or followup from the issue reporter label Jul 8, 2024
@howardjohn howardjohn closed this as not planned Won't fix, can't repro, duplicate, stale Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/environments kind/need more info Need more info or followup from the issue reporter
Projects
None yet
Development

No branches or pull requests

4 participants