Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: clarify annotation usage #51611

Closed
2 tasks done
kovaxur opened this issue Jun 18, 2024 · 2 comments
Closed
2 tasks done

Documentation: clarify annotation usage #51611

kovaxur opened this issue Jun 18, 2024 · 2 comments

Comments

@kovaxur
Copy link

kovaxur commented Jun 18, 2024

Is this the right place to submit this?

  • This is not a security vulnerability or a crashing bug
  • This is not a question about how to use Istio

Bug Description

Hi,
I try to use Istio resources annotations based on the following documentation:
https://istio.io/latest/docs/reference/config/annotations/

I try to use for example the includeInboundPorts annotation, which has two versions:

traffic.istio.io/includeInboundPorts
A comma separated list of inbound ports for which traffic is to be redirected to Envoy. The wildcard character ‘*’ can be used to configure redirection for all ports. An empty list will disable all inbound redirection.

traffic.sidecar.istio.io/includeInboundPorts
A comma separated list of inbound ports for which traffic is to be redirected to Envoy. The wildcard character ‘*’ can be used to configure redirection for all ports. An empty list will disable all inbound redirection.

For me the "traffic.istio.io" annotation was not working but the "traffic.sidecar.istio.io" was. Can you please extend the documentation, which to use when? Or maybe one is deprecated?

Thanks

Version

istioctl version
client version: 1.22.1
control plane version: 1.22.1
data plane version: 1.22.1 (57 proxies)

kubectl version
Client Version: v1.29.0
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.29.4-eks-036c24b

Additional Information

No response

@zirain
Copy link
Member

zirain commented Jun 18, 2024

see #49829

@zirain
Copy link
Member

zirain commented Jun 22, 2024

fixed by istio/istio.io#15307

@zirain zirain closed this as completed Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants