Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Helm global.externalIstiod for pilot env variable #51595

Closed
nshankar13 opened this issue Jun 15, 2024 · 0 comments · Fixed by #51596
Closed

Use Helm global.externalIstiod for pilot env variable #51595

nshankar13 opened this issue Jun 15, 2024 · 0 comments · Fixed by #51596
Assignees

Comments

@nshankar13
Copy link
Contributor

nshankar13 commented Jun 15, 2024

(This is used to request new product features, please visit https://github.com/istio/istio/discussions for questions on using Istio)

Describe the feature request

For multi-cluster primary-remote installation with Helm, externalIstiod needs to be set both for .Values.global and .Values.pilot.env. This PR consolidates the installation setup to just use .Values.global to set the pilot env variable. However, to prevent duplication (setting the same env variable twice), if EXTERNAL_ISTIOD is set via the pilot env variable, then respect that instead.

Describe alternatives you've considered

Affected product area (please put an X in all that apply)

[ ] Ambient
[ ] Docs
[ ] Dual Stack
[X] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Affected features (please put an X in all that apply)

[X] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants