Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null value in gateway chart values that leads to user values being overridden #51461

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Fix null value in gateway chart values that leads to user values being overridden #51461

merged 1 commit into from
Jun 7, 2024

Conversation

tjons
Copy link
Contributor

@tjons tjons commented Jun 7, 2024 •
edited by istio-policy-bot
Loading

Please provide a description of this PR:
This PR resolves #51460 by specifying the default values for containerSecurityContext and securityContext in the gateway helm chart as empty objects instead of null objects. Empty objects can be merged with a populated object in mergo v0.3.5, while nil maps cannot be merged.

@tjons tjons requested a review from a team as a code owner June 7, 2024 14:58
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jun 7, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: tjons / name: Tyler Schade (9f95bee)

@istio-policy-bot istio-policy-bot added area/environments release-notes-none Indicates a PR that does not require release notes. labels Jun 7, 2024
@istio-policy-bot
Copy link

😊 Welcome @tjons! This is either your first contribution to the Istio istio repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 7, 2024
@istio-testing
Copy link
Collaborator

Hi @tjons. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

bleggett
bleggett approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@bleggett bleggett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've actually never seen nil values being used like this in a chart, and we don't use them like this anywhere else at least. TY!

@bleggett bleggett added the cherrypick/release-1.22 Set this label on a PR to auto-merge it to the release-1.22 branch label Jun 7, 2024
@bleggett
Copy link
Contributor

bleggett commented Jun 7, 2024

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jun 7, 2024
@bleggett bleggett added the cherrypick/release-1.21 Set this label on a PR to auto-merge it to the release-1.21 branch label Jun 7, 2024
@istio-testing istio-testing merged commit 2de7e7f into istio:master Jun 7, 2024
28 checks passed
@dhawton
Copy link
Member

dhawton commented Jun 10, 2024

/cherry-pick release-1.22

@dhawton
Copy link
Member

dhawton commented Jun 10, 2024

/cherry-pick release-1.21

@istio-testing
Copy link
Collaborator

@dhawton: new pull request created: #51499

In response to this:

/cherry-pick release-1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@istio-testing istio-testing mentioned this pull request Jun 10, 2024
Merged
@istio-testing
Copy link
Collaborator

@dhawton: new pull request created: #51500

In response to this:

/cherry-pick release-1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@istio-testing istio-testing mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

@bleggett bleggett bleggett approved these changes

Assignees
No one assigned
Labels
area/environments cherrypick/release-1.21 Set this label on a PR to auto-merge it to the release-1.21 branch cherrypick/release-1.22 Set this label on a PR to auto-merge it to the release-1.22 branch ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

containerSecurityContext is not properly rendered with the gateway helm chart when using helm SDK
6 participants
@tjons @istio-policy-bot @istio-testing @bleggett @dhawton @howardjohn