Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add craigbox as Istio GitHub member #276

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Add craigbox as Istio GitHub member #276

merged 1 commit into from
Feb 12, 2020

Conversation

craigbox
Copy link
Contributor

List your company name, or indicate Individual if you're not affiliated with a company:
Google

Provide a link to at least one PR that you have successfully pushed to one
of the Istio repos:
istio/istio.io#5206 (They'll get more interesting, I promise.)

@craigbox craigbox requested a review from a team as a code owner February 12, 2020 16:51
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Feb 12, 2020
@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Feb 12, 2020
@istio-testing
Copy link
Contributor

Hi @craigbox. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sdake
sdake reviewed Feb 12, 2020
View reviewed changes
org/istio.yaml
@@ -44,6 +44,7 @@ orgs:
- clyang82
- cmluciano
- costinm
- craigbox
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @craigbox ! Welcome to the Istio community. This list is ASCII-betical. Can you correct the ordering?

org/istio.yaml
@@ -262,6 +263,7 @@ orgs:
- clyang82
- cmluciano
- costinm
- craigbox
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment applies.

@howardjohn
Copy link
Member

/ok-to-test

we have a test for alpha-ordering

@sdake
Copy link
Member

sdake commented Feb 12, 2020

/ok-to-test

we have a test for alpha-ordering

thanks, apparently I forgot my ABCs.. 😀

@smawson
Copy link
Contributor

smawson commented Feb 12, 2020

Who is this "self" person and why are we allowing them into our carefully curated community?!? (Please change the PR description).

@smawson smawson changed the title Add self as Istio GitHub member Add craigbox as Istio GitHub member Feb 12, 2020
smawson
smawson approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@smawson smawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh cool I can edit the title myself, fixed it for you :)

@istio-testing istio-testing merged commit c565b06 into istio:master Feb 12, 2020
@craigbox craigbox deleted the patch-1 branch February 12, 2020 21:57
@craigbox
Copy link
Contributor Author

Thanks all!

oaktowner pushed a commit to oaktowner/community that referenced this pull request Jul 7, 2020
@craigbox @oaktowner
Add self as Istio member (istio#276)
5df32cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdake sdake sdake left review comments

@howardjohn howardjohn howardjohn approved these changes

@smawson smawson smawson approved these changes

Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@craigbox @istio-testing @howardjohn @sdake @smawson @googlebot