Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick warning from release-1.1 #977

Merged
merged 1 commit into from
Jul 17, 2019
Merged

cherry-pick warning from release-1.1 #977

merged 1 commit into from
Jul 17, 2019

Conversation

frankbu
Copy link
Contributor

@frankbu frankbu commented Jul 15, 2019

cherry-pick of #903

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jul 15, 2019
Copy link
Member

@rshriram rshriram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frankbu, rshriram

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@geeknoid geeknoid merged commit 413c83f into release-1.2 Jul 17, 2019
mergify bot pushed a commit that referenced this pull request Jul 17, 2019
@frankbu frankbu deleted the sidecar-warn branch July 17, 2019 18:07
geeknoid pushed a commit that referenced this pull request Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants