Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The doc about EnvoyFilter is incorrect #3034

Closed
spacewander opened this issue Jan 4, 2024 · 0 comments · Fixed by #3049
Closed

The doc about EnvoyFilter is incorrect #3034

spacewander opened this issue Jan 4, 2024 · 0 comments · Fixed by #3049
Assignees

Comments

@spacewander
Copy link

(NOTE: This is used to report product bugs:
To report a security vulnerability, please visit https://istio.io/about/security-vulnerabilities/
To ask questions about how to use Istio, please visit https://discuss.istio.io
)

Bug description

The doc about EnvoyFilter is incorrect

Affected product area (please put an X in all that apply)

[ ] Configuration Infrastructure
[x] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience

Expected behavior

The doc about EnvoyFilter is correct.

Steps to reproduce the bug

The doc claims that "REPLACE is also supported" for EXTENSION_CONFIG:

// operation: ADD # REPLACE is also supported, and would override a cluster level resource with the same name.

But only Add is supported actually. See:

https://github.com/istio/istio/blob/c25ac2f7ffc75ecef1f45a9294672b10905012c6/pilot/pkg/networking/core/v1alpha3/envoyfilter/extension_configuration_patch.go#L35

Version (include the output of istioctl version --remote and kubectl version)

1.20.0

How was Istio installed?

Environment where bug was observed (cloud vendor, OS, etc)

Additionally, please consider attaching a cluster state archive by attaching
the dump file to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants