-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please use Buf Schema Registry (BSR) #2673
Comments
Has bufbuild/buf#933 been fixed? Or it doesn't matter and we just push protos there but not Go module? |
Thanks for the quick response! For our use case, we only care about the protos not the Go module. We want to use them in a Python operator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
(This is used to request new product features, please visit https://discuss.istio.io for questions on using Istio)
Describe the feature request
Y'all use buf. Awesome!
We would really appreciate if you used Buf Schema Registry. also.
We would love to use the protos you define in this repo in our bazel build and buf makes that easy with the
buf_dependencies
bazel rule.This rule requires the protos to be in the Buf Schema Registry but the Istio protos currently aren't. Given that you're already using buf to build your protos, using the schema registry should not involve new tooling, only doing a
buf push
as part of CI.Describe alternatives you've considered
Pull in Istio as a submodule without forking it. This wouldn't work for us because istio doesn't have bazel config in it's repo.
Forking istio and pulling it in as a submodule. Any upstream changes to the protos wouldn't be represented in our fork and we would need to add bazel configs.
Pulling in istio/api with bazel git_repository. We need to traverse the entire bazel dependency tree manually for any protos we pull in.
Affected product area (please put an X in all that apply)
[x ] Configuration Infrastructure
[ ] Docs
[x ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[x ] User Experience
Additional context
The text was updated successfully, but these errors were encountered: