-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc.: Incorrect "allowed" instead of "matches" in Rule documentation #2071
Comments
Relatedly: Also, a bit earlier in that section, the text says:
Don't the first two cases there contradict the intent of the "any ... is allowed" wording? Consider an empty If the later text is supposed to be carving out an exception to what the earlier text says, then those two bits of next need to be right next to each other. Actually, it looks like other wording needs reworking to actually say what it means and say it clearly. (For example, the wording " |
Depending on release, this would come from: https://github.com/istio/api/blob/release-1.10/security/v1beta1/authorization_policy.proto. |
Yeah I think this is stale from when we did not have DENY mode |
In the page section currently at https://istio.io/latest/docs/reference/config/security/authorization-policy/#Rule, about each of
from
,to
, andwhen
, it says, "If not set, any [source/operation/condition] is allowed."Isn't that very wrong? Whether any source/operation/condition is allowed or denied depends on whether the action is
ALLOW
orDENY
, right?Shouldn't the referenced text say that any source/operation/condition matches, not that it is allowed?
The text was updated successfully, but these errors were encountered: