Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple 'Set-Cookie' header within Header struct (VirtualService) #1022

Open
fentas opened this issue Aug 7, 2019 · 1 comment
Open

Multiple 'Set-Cookie' header within Header struct (VirtualService) #1022

fentas opened this issue Aug 7, 2019 · 1 comment
Assignees
Labels
area/networking kind/enhancement lifecycle/needs-triage Indicates a new PR or issue needs to be triaged

Comments

@fentas
Copy link

fentas commented Aug 7, 2019

Describe the feature request
Regarding type Headers_HeaderOperations struct
https://github.com/istio/api/blob/master/networking/v1alpha3/virtual_service.pb.go#L793-L804

As the key of Add attribute reflects the header name, setting multiple keys/headers like Set-Cookie is impossible.
Is there a way to set multiple Set-Cookie headers like separating cookies definitions with , (tried and failed). This would require that istio would unfold this to separate header.

Describe alternatives you've considered

As I have the need to set 2 cookies right now I am doing kind of a workaround and set one within the Http struct and one into the Destination. This works and envoy delivers two separate Set-Cookie headers.

Affected product area (please put an X in all that apply)

[x] Configuration Infrastructure
[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience

Additional context

But we have the use case which would require to set more than 2 Cookies within one route.

@kuuji
Copy link

kuuji commented Jul 6, 2021

Any update on this? We're having the same issue and require setting multiple cookies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking kind/enhancement lifecycle/needs-triage Indicates a new PR or issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

6 participants