Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpack strip error #411

Closed
rzyanhao opened this issue Apr 12, 2024 · 3 comments
Closed

unpack strip error #411

rzyanhao opened this issue Apr 12, 2024 · 3 comments

Comments

@rzyanhao
Copy link

rzyanhao commented Apr 12, 2024

this error is caused by this commit : fe8cd57
image
as the red lines in this picture, the "p" passed into to stripAbsolutePath(p) is not right, because it may be modified when it has strip

@isaacs
Copy link
Owner

isaacs commented Apr 12, 2024

What is the error that you are referring to? How can I reproduce it?

@rzyanhao
Copy link
Author

for example, the entry.path is code//a/b/c/d.json, its an abnormal tar file, but it exists. And stirp is 1.
In 6.2.0, the final absolute path will be /Users/admin/unpacked/a/b/c/d.json, it's right;
in 6.2.1, the final absolute path will be /a/b/c/d.json, this will cause error, which lead to checkpath return false;

@isaacs
Copy link
Owner

isaacs commented Jun 19, 2024

@rzyanhao Please provide a tar file and some code that shows the error, not an english description. I only can understand this sort of thing if it's expressed in code. As far as I can tell, the code is correct now, and was not correct before.

@isaacs isaacs closed this as completed Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants