Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update channels.csv #10558

Merged
merged 28 commits into from
Apr 13, 2024
Merged

Update channels.csv #10558

merged 28 commits into from
Apr 13, 2024

Conversation

AntiPontifex
Copy link
Contributor

See title

BellezaEmporium
BellezaEmporium previously approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@BellezaEmporium BellezaEmporium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@BellezaEmporium
Copy link
Contributor

data/channels.csv
146 "2STV.sn" must be derived from the channel name "2sTV" and the country code "SN". Fix is to call the channel "2STV".
203 "4DmasNoticiasTV.py" must be derived from the channel name "4DMas Noticias TV" and the country code "PY". Fix is to call the channel "4Dmas Noticias TV".
224 "4TVNews.in" must be derived from the channel name "4tv News" and the country code "IN". Fix is to call the channel "4TV News".

@AntiPontifex
Copy link
Contributor Author

data/channels.csv 146 "2STV.sn" must be derived from the channel name "2sTV" and the country code "SN". Fix is to call the channel "2STV". 203 "4DmasNoticiasTV.py" must be derived from the channel name "4DMas Noticias TV" and the country code "PY". Fix is to call the channel "4Dmas Noticias TV". 224 "4TVNews.in" must be derived from the channel name "4tv News" and the country code "IN". Fix is to call the channel "4TV News".

Fixed

BellezaEmporium
BellezaEmporium previously approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@BellezaEmporium BellezaEmporium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, twice.

AntiPontifex
AntiPontifex commented Apr 3, 2024
View reviewed changes
Copy link
Contributor Author

@AntiPontifex AntiPontifex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve me

@BellezaEmporium
Copy link
Contributor

Merge conflict on. Will check when i'm in front of my 'puter

@BellezaEmporium
Copy link
Contributor

As of now i'll ask to refrain from adding further changes, the time for us to solve the merge conflicts that are in there.

BellezaEmporium
BellezaEmporium previously approved these changes Apr 8, 2024
View reviewed changes
@BellezaEmporium
Copy link
Contributor

data/channels.csv
345 "92NewsUK.pk" must be derived from the channel name "92 News UK" and the country code "UK"
414 "AagTV.pk" must be derived from the channel name "AAG TV" and the country code "PK"
431 "AathavanTV.in" must be derived from the channel name "Aathavan TV" and the country code "UK"
433 "AAVISIE.nl" must be derived from the channel name "AAvisie TV" and the country code "NL"
586 "ABXplore.be" has an invalid languages "fre"
779 "AflamTV.ma" has an invalid languages "ber"
229 54UnityTV.th: "owners[0]" with value "D One Solution Co.,Ltd" fails to match the required pattern: /^[^",]+$/
639 ActionNewsJaxNow.us: "owners[0]" with value "Hoffman Communications, Inc" fails to match the required pattern: /^[^",]+$/

@AntiPontifex
Copy link
Contributor Author

Tried to add fixes; message, Lane is received. Notify me when it is ok to proceed. Thanks.

BellezaEmporium
BellezaEmporium approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@BellezaEmporium BellezaEmporium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and this time, it's all fixed.

AntiPontifex
AntiPontifex commented Apr 9, 2024
View reviewed changes
Copy link
Contributor Author

@AntiPontifex AntiPontifex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you record, LGTM

@AntiPontifex
Copy link
Contributor Author

I seek your approval...

@AntiPontifex
Copy link
Contributor Author

Is it possible to add reviewers, Lane?

AntiPontifex
AntiPontifex commented Apr 13, 2024
View reviewed changes
Copy link
Contributor Author

@AntiPontifex AntiPontifex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Sphinxroot :) Hope all is well with you.

@BellezaEmporium
Copy link
Contributor

Approval not confirmed sadly. Will need another reviewer on the check.

@AntiPontifex
Copy link
Contributor Author

Copy that

@Alstruit Alstruit merged commit 184b9c0 into iptv-org:master Apr 13, 2024
1 check passed
@AntiPontifex
Copy link
Contributor Author

AntiPontifex commented Apr 14, 2024 •
edited
Loading

Thanks to all involved! More changes will be forthcoming ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BellezaEmporium BellezaEmporium BellezaEmporium approved these changes

@Alstruit Alstruit Alstruit approved these changes

@Sphinxroot Sphinxroot Sphinxroot approved these changes

@Dum4G Dum4G Awaiting requested review from Dum4G

@MapGuy11 MapGuy11 Awaiting requested review from MapGuy11

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AntiPontifex @BellezaEmporium @Alstruit @Sphinxroot @ProPontifex