-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic smoke tests for the tools #981
Comments
Absolutely! How about adding a --dry-run flag to the most popular tools (with others to follow) which only compiles the bpf program with the common defaults and then does a cleanup + exit? |
Yes to such smoke tests. I'd test:
No tool should spit out a Python exception trace in these conditions. |
Oh, and we could add --dry-run to tools that initialized everything and then exited. I would not put --dry-run in the man page, and I'd hide it from the USAGE message if possible. |
We have reasonably solid tests for libbcc and the Python modules, but nothing at all that exercises the tools. Seeing as a lot of people use the tools from bcc, and nothing else, we should provide at least some very basic smoke tests that would ensure tools don't break in a completely obvious way. Some of the more obvious ways we've seen recently:
For a lot of tools, just running
timeout -s KILL 1s the_tool
and checking that we don't get an error status is sufficient for a basic smoke test. Testing the actual output would of course be better, but we have to start somewhere.Thoughts? @brendangregg @4ast @drzaeus77
The text was updated successfully, but these errors were encountered: