Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): allow configuring argon for JWT #601

Merged
merged 5 commits into from
Sep 22, 2022
Merged

Conversation

DaughterOfMars
Copy link
Collaborator

No description provided.

Copy link
Contributor

@grtlr grtlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not expose all the argon stuff in the config.toml. We should either

  • provide sub-command inx-chronicle jwt, or
  • automatically generate the JWT in a dedicated output folder.

For both options, we should choose sensible defaults where possible.

@DaughterOfMars
Copy link
Collaborator Author

I would not expose all the argon stuff in the config.toml. We should either

* provide sub-command `inx-chronicle jwt`, or

* automatically generate the JWT in a dedicated output folder.

For both options, we should choose sensible defaults where possible.

I don't understand. This is fundamentally JWT configuration, so it should go there.

@grtlr grtlr merged commit d696a6a into main Sep 22, 2022
@grtlr grtlr deleted the feat/api/config-argon branch September 22, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants