Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): inputs commitment conversion #459

Merged
merged 1 commit into from
Jul 25, 2022
Merged

fix(types): inputs commitment conversion #459

merged 1 commit into from
Jul 25, 2022

Conversation

DaughterOfMars
Copy link
Collaborator

@DaughterOfMars DaughterOfMars commented Jul 25, 2022 •
edited by grtlr
Loading

Closes #458.

grtlr
grtlr reviewed Jul 25, 2022
View reviewed changes
Copy link
Contributor

@grtlr grtlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it take much work to write a test case for this?

@DaughterOfMars
Copy link
Collaborator Author

Would it take much work to write a test case for this?

There's not really any way we can test the validity without database access. I don't think there's any need though, since the core issue is that I had incorrectly built the value when I should have just copied it.

@grtlr grtlr merged commit ceb736b into main Jul 25, 2022
@grtlr grtlr deleted the fix/inputs-commitment branch July 25, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grtlr grtlr grtlr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inputsCommitment in blocks/{blockId} yields different value from Hornet
2 participants
@DaughterOfMars @grtlr