feat(runtime)!: allow adding streams to own event loop #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 14, 2022 11:43
…ove INX connection retry logic to init. Better status error handling.
…ability to add streams as supervisor.
Alex6323
reviewed
Jun 21, 2022
Alex6323
reviewed
Jun 21, 2022
Alex6323
reviewed
Jun 21, 2022
Alex6323
previously approved these changes
Jun 22, 2022
Alex6323
approved these changes
Jun 22, 2022
grtlr
approved these changes
Jun 22, 2022
grtlr
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way adding additional streamed events to actor event loops works. Previously, the supervisor was required to construct the stream and add it via
SpawnConfig. This put too much of the child actor's logic in the hands of the supervisor. This PR adds theadd_streammethod to theActorContext, which allows actors to add streams they construct to their own event loop.