fix(db): Rename message_id to _id
#172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvdrz
previously approved these changes
May 18, 2022
Alex6323
previously approved these changes
May 18, 2022
| @@ -34,8 +34,16 @@ pub struct InfoResponse { | |||
|
|
|||
| impl_success_response!(InfoResponse); | |||
|
|
|||
| #[derive(Clone, Debug, Serialize, Deserialize)] | |||
| pub struct SyncDataResponse(pub SyncData); | |||
| /// An aggregation type that represents the ranges of completed milestones and gaps. | |||
There was a problem hiding this comment.
This is needed for the syncer, so relegating it to the API is no bueno
There was a problem hiding this comment.
I think this is resolved for now 
There was a problem hiding this comment.
No, we still need it in the syncer
pvdrz
approved these changes
May 19, 2022
|
I went ahead and merged this, we can add move it later again if we need to, but my goal is to merge #163 too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.