Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Historical data is not working as documented #20

Closed
href opened this issue Oct 7, 2015 · 3 comments
Closed

Historical data is not working as documented #20

href opened this issue Oct 7, 2015 · 3 comments

Comments

@href
Copy link

href commented Oct 7, 2015

I tried all of the following commands with varying years and the result is always the same (the hash of all resulting files matches):

  • make topo/ch-municipalities.json YEAR=2014
  • make topo/ch-municipalities.json YEAR=2014 PROPERTIES=id,name
  • make all YEAR=2014 PROPERTIES=id,name

When generating the files with the name of the municipality I can also verify that the result is not correct with historical data like this one:

The municipality "Calanca" in Graubünden only exists since 2015, when it formed out of a number of other municipalities: https://en.wikipedia.org/wiki/Calanca

In all datasets however, "Calanca" is present. Not say "Arvigo".

I tried to find the cause of the problem but I'm afraid due to my limited understanding of the matter (and make) I didn't get anywhere :)

@jstcki
Copy link
Contributor

jstcki commented Oct 7, 2015

Running make clean-generated before switching the year should help.

@jstcki jstcki closed this as completed Oct 7, 2015
@href
Copy link
Author

href commented Oct 8, 2015

Thanks, that's it! I was removing the topo folder each time, but it didn't occur to me to check the other files 😓

@jstcki
Copy link
Contributor

jstcki commented Oct 8, 2015

Thanks for verifying! I guess it wasn't obvious and I've added a note to the README.

Also it got me thinking about #10 again …

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants