[SYCL] Refactor compile-time properties' detail:: traits
#16099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Prefer to perform the check on values and not keys * Use `std::is_empty_v` to distinguish between compile/run-time properties * Remove unused traits (including the ones that became such after changes above) Technically, I'm (almost?) able to remove the `compile_time_property_key` and `run_time_property_key` base classes at this point, but I'd prefer to do that later once `property_value` template is removed from the spec too, as both of these changes will require updating all the properties and I'd rather do that once.
bd56319
to
824b517
Compare
steffenlarsen
approved these changes
Nov 18, 2024
| // check if a compile-time property is valid for annotated_ptr | ||
| static_assert(!detail::IsCompileTimePropertyValue<Prop>::value || | ||
| is_valid_property<T *, Prop>::value, | ||
| static_assert(!std::is_empty_v<Prop> || is_valid_property<T *, Prop>::value, |
There was a problem hiding this comment.
Could we consider aliasing std::is_empty_v to make the use of it here clearer? It might not be clear that it has to do with whether or not the property has runtime contents.
There was a problem hiding this comment.
Sure, but ideally we need to refactor it one level higher - this entire trait needs to lifted to C++17 at the very least (with pack expansion).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::is_empty_vto distinguish between compile/run-time propertiesTechnically, I'm (almost?) able to remove the
compile_time_property_keyandrun_time_property_keybase classes at this point, but I'd prefer to do that later onceproperty_valuetemplate is removed from the spec too, as both of these changes will require updating all the properties and I'd rather do that once.