[SYCL][clang] Emit default template arguments in integration header #16005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For free function kernels support clang forward declares the kernel
itself as well as its parameter types. In case a free function kernel has a
parameter that is templated and has a default template argument, all
template arguments including arguments that match default arguments must
be printed in kernel's forward declarations, for example
```
template <typename T, typename = int> struct Arg {
T val;
};
// For the kernel
SYCL_EXT_ONEAPI_FUNCTION_PROPERTY(
(ext::oneapi::experimental::nd_range_kernel<1>)) void foo(Arg<int> arg) {
arg.val = 42;
}
// Integration header must contain
void foo(Arg<int, int> arg);
```
Unfortunately, even though integration header emission already has
extensive support for forward declarations priting,
some modifications to clang's type printing are still required.
infrastructure, since neither of existing PrintingPolicy flags help to
reach the correct result.
Using `SuppressDefaultTemplateArgs = true` doesn't help without printing
canonical types, printing canonical types for the case like
```
template <typename T>
SYCL_EXT_ONEAPI_FUNCTION_PROPERTY(
(ext::oneapi::experimental::nd_range_kernel<1>)) void foo(Arg<T> arg) {
arg.val = 42;
}
// Printing canonical types is causing the following integration header
template <typename T>
void foo(Arg<type-parameter-0-0, int> arg);
```
Using `SkipCanonicalizationOfTemplateTypeParms` field of printing policy
doesn't help here since at the one point where it is checked we take
canonical type of `Arg`, not its parameters and it will contain template
argument types in canonical type after that.
lbushi25
approved these changes
Nov 11, 2024
| Policy.FullyQualifiedName = true; | ||
| Policy.EnforceScopeForElaboratedTypes = true; | ||
|
|
||
| // SuppressDefaultTemplateArguments is a downstream addition that suppresses |
There was a problem hiding this comment.
I think an example in the comments would be helpful here. Probably the same one in PR description. Just reading these is very confusing without context.
premanandrao
approved these changes
Nov 14, 2024
|
@elizabethandrews , are you ok with the change? |
elizabethandrews
approved these changes
Nov 15, 2024
|
@intel/llvm-gatekeepers , the PR is ready for submit. Please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For free function kernels support clang forward declares the kernel itself as well as its parameter types. In case a free function kernel has a parameter that is templated and has a default template argument, all template arguments including arguments that match default arguments must be printed in kernel's forward declarations, for example
Unfortunately, even though integration header emission already has extensive support for forward declarations priting, some modifications to clang's type printing are still required, since neither of existing PrintingPolicy flags help to reach the correct result.
Using
SuppressDefaultTemplateArgs = truedoesn't help without printing canonical types, printing canonical types for the case likeUsing
SkipCanonicalizationOfTemplateTypeParmsfield of printing policy doesn't help here since at the one point where it is checked we take canonical type ofArg, not its parameters and it will contain template argument types in canonical type after that.