Add option -include-footer. #14402
Merged
Add option -include-footer. #14402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdtoguchi
reviewed
Jul 10, 2024
|
As I'm the primary author of the driver changes, @hchilama can you review the driver changes? |
PietroGhg
approved these changes
Jul 12, 2024
|
@intel/llvm-gatekeepers Can this PR be merged in? The failure is not related to this patch. Thanks. |
|
@sarnex - https://github.com/intel/llvm/blob/sycl/sycl/doc/developer/ContributeToDPCPP.md#commit-message . Please pay attention to that while merging patches, we need such tags at least for creating Release Notes. |
|
@dm-vodopyanov Sorry about that, I will catch it in the future. Thanks for reminding me. |
zahiraam
added a commit
to zahiraam/llvm-1
that referenced
this pull request
Aug 12, 2024
This reverts commit 20969b4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is joint work with @mdtoguchi.
It adds the
-include-footeroption to pull in the footer. The syntax is:-include-footer=path-to-footer.hThis will have the effect of removing the append phase in the compilation process.
It also implements the required changes to the pre-processed file.