-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vdp): add component definition list endpoint #274
Merged
jvallesm
merged 6 commits into
main
from
jvalles/ins-3680-create-component-list-endpoint
Feb 26, 2024
Merged
feat(vdp): add component definition list endpoint #274
jvallesm
merged 6 commits into
main
from
jvalles/ins-3680-create-component-list-endpoint
Feb 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Component and operator definition types have been placed in a single file, component_definition.proto.
3b6b745
to
4883630
Compare
triggered by commit: 7005107
jvallesm
commented
Feb 26, 2024
jvallesm
commented
Feb 26, 2024
31dda72
to
2cbc7c0
Compare
triggered by commit: 11f00c9
donch1989
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Feb 26, 2024
jvallesm
added a commit
to instill-ai/component
that referenced
this pull request
Feb 27, 2024
Because - instill-ai/protobufs#274 removed the Blockchain connector type This commit - Updates `compogen` with the new connector type
jvallesm
added a commit
to instill-ai/pipeline-backend
that referenced
this pull request
Feb 27, 2024
Because - instill-ai/protobufs#274 removed the Blockchain connector type and modified the connector and operator list view type. - Once instill-ai/connector#131 is merged, `numbers` connector will become an application connector. This commit - Updates the auto-generated proto Go code, adapting the backend to the changes: - Modifies the Blockchain enum value in the database via a migration. - Modifies type conversions to take Application connector into account. - Removes deprecated lookup methods. - Updates `VIEW_XXX` enum values.
EiffelFly
pushed a commit
to instill-ai/console
that referenced
this pull request
Feb 28, 2024
Because - instill-ai/protobufs#274 removed the Blockchain connector type. - Once instill-ai/connector#131 is merged, `numbers` connector will become an application connector. This commit - Updates `blockchain` references to `application`
heiruwu
pushed a commit
to instill-ai/api-gateway
that referenced
this pull request
Feb 29, 2024
Because - Website needs to access a paginated list of components This commit - Opens the endpoint introduced in instill-ai/protobufs#274
heiruwu
pushed a commit
to instill-ai/api-gateway
that referenced
this pull request
Feb 29, 2024
Because - Website needs to access a paginated list of components This commit - Opens the endpoint introduced in instill-ai/protobufs#274
namwoam
pushed a commit
to namwoam/component
that referenced
this pull request
Jun 24, 2024
…ai#61) Because - instill-ai/protobufs#274 removed the Blockchain connector type This commit - Updates `compogen` with the new connector type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This commit
component_definition.proto
CONNECTOR_BLOCKCHAIN
byCONNECTOR_APPLICATION
(INS-3739)