Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vdp): add component definition list endpoint #274

Merged
merged 6 commits into from
Feb 26, 2024

Conversation

jvallesm
Copy link
Collaborator

@jvallesm jvallesm commented Feb 26, 2024

Because

  • Component page requires unified filtering and pagination.

This commit

  • Adds a "component list" endpoint to the public VDP API.
  • Unifies the component view and removes connector and operator view enums.
    • Connector and operator definition messages are unified in component_definition.proto
  • Replaces CONNECTOR_BLOCKCHAIN by CONNECTOR_APPLICATION (INS-3739)
  • Removes operator / connector definition lookup endpoints (unused).

@jvallesm jvallesm self-assigned this Feb 26, 2024
Copy link

linear bot commented Feb 26, 2024

@jvallesm jvallesm changed the title feat: add component definition list endpoint feat(vdp): add component definition list endpoint Feb 26, 2024
Component and operator definition types have been placed in a single
file, component_definition.proto.
@jvallesm jvallesm force-pushed the jvalles/ins-3680-create-component-list-endpoint branch from 3b6b745 to 4883630 Compare February 26, 2024 08:55
@jvallesm jvallesm marked this pull request as ready for review February 26, 2024 09:03
@jvallesm jvallesm force-pushed the jvalles/ins-3680-create-component-list-endpoint branch from 31dda72 to 2cbc7c0 Compare February 26, 2024 10:03
Copy link
Member

@donch1989 donch1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jvallesm jvallesm merged commit 16afda7 into main Feb 26, 2024
1 check passed
@jvallesm jvallesm deleted the jvalles/ins-3680-create-component-list-endpoint branch February 26, 2024 10:11
jvallesm added a commit to instill-ai/component that referenced this pull request Feb 27, 2024
Because

- instill-ai/protobufs#274 removed the
Blockchain
  connector type

This commit

- Updates `compogen` with the new connector type
jvallesm added a commit to instill-ai/pipeline-backend that referenced this pull request Feb 27, 2024
Because

- instill-ai/protobufs#274 removed the
Blockchain
  connector type and modified the connector and operator list view type.
- Once instill-ai/connector#131 is merged,
`numbers` connector will become an application connector.

This commit

- Updates the auto-generated proto Go code, adapting the backend to the
changes:
  - Modifies the Blockchain enum value in the database via a migration.
- Modifies type conversions to take Application connector into account.
  - Removes deprecated lookup methods.
  - Updates `VIEW_XXX` enum values.
EiffelFly pushed a commit to instill-ai/console that referenced this pull request Feb 28, 2024
Because

- instill-ai/protobufs#274 removed the
Blockchain
  connector type.
- Once instill-ai/connector#131 is merged,
`numbers` connector will become an application connector.

This commit

- Updates `blockchain` references to `application`
heiruwu pushed a commit to instill-ai/api-gateway that referenced this pull request Feb 29, 2024
Because

- Website needs to access a paginated list of components

This commit

- Opens the endpoint introduced in
instill-ai/protobufs#274
heiruwu pushed a commit to instill-ai/api-gateway that referenced this pull request Feb 29, 2024
Because

- Website needs to access a paginated list of components

This commit

- Opens the endpoint introduced in
instill-ai/protobufs#274
namwoam pushed a commit to namwoam/component that referenced this pull request Jun 24, 2024
…ai#61)

Because

- instill-ai/protobufs#274 removed the
Blockchain
  connector type

This commit

- Updates `compogen` with the new connector type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👋 Done
3 participants