Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mgmt): refactor APIs for Get and Patch authenticated user #261

Merged
merged 4 commits into from
Feb 5, 2024
Merged

feat(mgmt): refactor APIs for Get and Patch authenticated user #261

merged 4 commits into from
Feb 5, 2024

Conversation

donch1989
Copy link
Member

@donch1989 donch1989 commented Feb 2, 2024 •
edited

Because

  • Some user information is sensitive and should not be accessed by other users.
  • We didn't return the onboarding process status, making it difficult for the Console to handle the user onboarding workflow.

This commit

  • Adds a new GetAuthenticatedUser endpoint for getting authenticated users' own data.
  • Introduces the OnboardingStatus enum to indicate the status of the onboarding process.
  • Removes sensitive data from the responses of GetUser and ListUsers.
  • Changes org_name in User to company_name to prevent confusion.

@linear Linear
Copy link

linear bot commented Feb 2, 2024

INS-3563 Seperate create and update user API

@donch1989 donch1989 force-pushed the huitang/ins-3563 branch 3 times, most recently from f5b5367 to 155ae85 Compare February 2, 2024 03:51
@donch1989 donch1989 marked this pull request as draft February 2, 2024 04:48
@donch1989 donch1989 changed the title feat(mgmt): separate PatchAuthenticatedUser API into CreateUser and UpdateUser APIs feat(mgmt): refactor APIs for Get and Patch authenticated user Feb 5, 2024
@donch1989 donch1989 force-pushed the huitang/ins-3563 branch 3 times, most recently from e913eac to 7144797 Compare February 5, 2024 05:21
@donch1989 donch1989 marked this pull request as ready for review February 5, 2024 08:37
@donch1989
Copy link
Member Author

donch1989 commented Feb 5, 2024 •
edited

Hi @EiffelFly, please check this PR for the mgmt endpoints refactor.
Hi @jvallesm, please also help check the document.
Thanks!

jvallesm
jvallesm reviewed Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@jvallesm jvallesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for waiting on my review 🙇 I added some questions and suggestions but none is a blocking comment. Let me know what you think!

core/mgmt/v1beta/mgmt.proto Show resolved Hide resolved
core/mgmt/v1beta/mgmt.proto Outdated Show resolved Hide resolved
core/mgmt/v1beta/mgmt.proto Outdated Show resolved Hide resolved
core/mgmt/v1beta/mgmt_public_service.proto Show resolved Hide resolved
core/mgmt/v1beta/mgmt_public_service.proto Outdated Show resolved Hide resolved
core/mgmt/v1beta/mgmt_public_service.proto Outdated Show resolved Hide resolved
core/mgmt/v1beta/mgmt_public_service.proto Show resolved Hide resolved
core/mgmt/v1beta/mgmt.proto Show resolved Hide resolved
@donch1989
Copy link
Member Author

Thanks for waiting on my review 🙇 I added some questions and suggestions but none is a blocking comment. Let me know what you think!

@jvallesm Thanks for the review! 🙇

@donch1989 donch1989 merged commit 0e4e9e6 into main Feb 5, 2024
@donch1989 donch1989 deleted the huitang/ins-3563 branch February 5, 2024 10:51
@droplet-bot droplet-bot mentioned this pull request Feb 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvallesm jvallesm jvallesm approved these changes

@heiruwu heiruwu Awaiting requested review from heiruwu heiruwu is a code owner

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

Assignees
No one assigned
Labels
None yet
Projects
🔮 Instill Core
Status: 👋 Done
Milestone
No milestone
3 participants
@donch1989 @jvallesm @droplet-bot