Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] remove insecurity verification setting in Instill Model connector #561

Open
1 task done
donch1989 opened this issue Jan 8, 2024 · 2 comments
Open
1 task done
Assignees

Comments

@donch1989
Copy link
Member

Is There an Existing Issue for This?

  • I have searched the existing issues

Where are you aiming to make improvements?

Instill Core

Is your Proposal Related to a Problem?

Related discussion

Using insecure TLS verification in a connection is not a good practice. The default setting for InsecureSkipVerify should be false, and we should connector configuration to set it to true only when necessary.

Describe Your Proposed Improvement

  • make InsecureSkipVerify as a setting in Instill Model connector configuration.

Highlight the Benefits

No response

Anything Else?

No response

Copy link

github-actions bot commented Feb 8, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 15, 2024
@donch1989 donch1989 reopened this Feb 15, 2024
@donch1989 donch1989 self-assigned this Feb 15, 2024
@pinglin pinglin transferred this issue from instill-ai/community May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant