Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tabulate_rsp_biomarkers and source tabulation function h_tab_one_biomarker to avoid degenerative structure #1195

Open
Melkiades opened this issue Feb 22, 2024 · 0 comments

Comments

@Melkiades
Copy link
Contributor

Looking at the code, this function seems to generate a very odd structure for the table. It is based on the row_type column where it can be a split or analysis. If the latter a summarize_row_groups is done and the whole table is then do.call(rbind) together. These are both things that should be avoided. Ideally we should use splits and analysis correctly without rbind if it is from the same data-set, while, if we need to use a pre-calculated data, we should probably rely more on df_to_tt. See h_tab_one_biomarker source code for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant