Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing useSyncExternalStore with useState #77

Closed
inokawa opened this issue May 7, 2023 · 0 comments · Fixed by #81 or #88
Closed

Consider replacing useSyncExternalStore with useState #77

inokawa opened this issue May 7, 2023 · 0 comments · Fixed by #81 or #88

Comments

@inokawa
Copy link
Owner

inokawa commented May 7, 2023

useSyncExternalStore is designed to update synchronously for consistency, that means it can't be async or batched.
At least in this lib, which has store by components and have much less possibility of tearing, useState might be more suitable because we can choose sync/async and it will reduce bundle size a bit with removing use-sync-external-store shim package.

reactwg/react-18#86
facebook/react#25191 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant